Hello Yida Wu, Abhishek Rawat, Jason Fehr, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24429
to look at the new patch set (#5).
Change subject: IMPALA-15090: Make Query Profile Redaction DOM to DOM
......................................................................
IMPALA-15090: Make Query Profile Redaction DOM to DOM
Remove profile JSON serialization from redaction and
GenerateAiAnalysisFromProfile by extracting redaction inputs
from DOM strings and estimating profile size via DOM traversal.
Cache redacted profile size in QueryProfileRedactor and pass
it to profile parsing to avoid extra JsonToString() allocations
in the AI profile-analysis flow.
Testing:
Added targeted unit coverage in query-profile-redaction-test
for the DOM-based helper path: nested JSON string collection,
regex matching/dedup across collected DOM strings, IPv6
candidate filtering with validation, and serialized-size
estimation parity checks. Existing redaction regression tests
continue to validate SQL/user/IP/table/column/host masking and
unredaction behavior after removing profile text round-trips
from the analysis flow. Also validated the end-to-end AI
profile analysis feature on a local Impala setup.
Assisted-by: Codex 5.3 (Cursor)
Change-Id: I8b8ad721a5531e9d257cf6e54b83ea3ee9734039
---
M be/src/service/query-profile-ai-analysis.cc
M be/src/service/query-profile-redaction-test.cc
M be/src/service/query-profile-redaction.cc
M be/src/service/query-profile-redaction.h
4 files changed, 350 insertions(+), 147 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/24429/5
--
To view, visit http://gerrit.cloudera.org:8080/24429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8b8ad721a5531e9d257cf6e54b83ea3ee9734039
Gerrit-Change-Number: 24429
Gerrit-PatchSet: 5
Gerrit-Owner: Gokul Kolady <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
