Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24429 )
Change subject: IMPALA-15090: Make Query Profile Redaction DOM to DOM ...................................................................... Patch Set 5: (9 comments) http://gerrit.cloudera.org:8080/#/c/24429/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24429/3//COMMIT_MSG@12 PS3, Line 12: Cache redacted profile size in QueryProfileRedactor and pass > Please add information about how this change was tested. Done http://gerrit.cloudera.org:8080/#/c/24429/3/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24429/3/be/src/service/query-profile-ai-analysis.cc@935 PS3, Line 935: > redacted_profile_size_bytes is only used in one place (line 940). Eliminat Done http://gerrit.cloudera.org:8080/#/c/24429/3/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24429/3/be/src/service/query-profile-redaction.cc@332 PS3, Line 332: } : return results; : } : : // Collects unique IPv6 matches across a sequence of text inputs. : static vector<string> CollectIpv6MatchesFromTexts(const vector<string_view>& texts) { : vector<string> candidates = CollectRegexMatchesFromTexts(texts, IPV6_CANDIDATE_RE); : vector<string> results; : for (string& candidate : candidates) { : if (!IsValidIpv6Address(candidate)) continue; : results.emplace_back(move(candidate)); : } : return results; : } > This code block is structured in a way that is somewhat confusing to unders Done http://gerrit.cloudera.org:8080/#/c/24429/3/be/src/service/query-profile-redaction.cc@349 PS3, Line 349: auto estimate_escaped_string_size = [](const string_view& text) -> size_t { > Please add a ctest test to cover this function. Done http://gerrit.cloudera.org:8080/#/c/24429/3/be/src/service/query-profile-redaction.cc@356 PS3, Line 356: case '\f': > Please add a ctest test to cover this function. Done http://gerrit.cloudera.org:8080/#/c/24429/3/be/src/service/query-profile-redaction.cc@371 PS3, Line 371: bool first = true; > Please add a ctest test to cover this function. Done http://gerrit.cloudera.org:8080/#/c/24429/3/be/src/service/query-profile-redaction.cc@369 PS3, Line 369: if (value.IsObject()) { : size_t size = 2; : bool first = true; : for (auto it = value.MemberBegin(); it != value.MemberEnd(); ++it) { : if (!first) ++size; : first = false; : size += estimate_escaped_string_size( : string_view(it->name.GetString(), it->name.GetStringLength())); : ++size; : size += EstimateSerializedJsonSize(it->value); : } : return size; : } : > Can this whole function be replaced by calling CollectRegexMatchesFromTexts Done http://gerrit.cloudera.org:8080/#/c/24429/3/be/src/service/query-profile-redaction.cc@384 PS3, Line 384: size_t size = 2; > Please clarify the unit of the returned size (bytes, kilobytes, etc). Done http://gerrit.cloudera.org:8080/#/c/24429/3/be/src/service/query-profile-redaction.cc@385 PS3, Line 385: bool first = true; > Please add a ctest test to cover this function. Done -- To view, visit http://gerrit.cloudera.org:8080/24429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b8ad721a5531e9d257cf6e54b83ea3ee9734039 Gerrit-Change-Number: 24429 Gerrit-PatchSet: 5 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 16 Jun 2026 01:41:05 +0000 Gerrit-HasComments: Yes
