Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24337 )
Change subject: IMPALA-14954: Support ADMIN OPTION clause for GRANT/REVOKE ROLE ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/main/java/org/apache/impala/analysis/ShowRolesPrincipalStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowRolesPrincipalStmt.java: http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/main/java/org/apache/impala/analysis/ShowRolesPrincipalStmt.java@40 PS8, Line 40: Preconditions.checkState(principalType == TPrincipalType.USER || nit: checkArgument would be more appropriate. http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@172 PS8, Line 172: || params.getRequesting_user().equals(params.getGrant_user())); Is this right that it's an admin op of requesting user equals grant user? I see that's the logic we had before, but don't understand it. -- To view, visit http://gerrit.cloudera.org:8080/24337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e7c9ba091bc15271c7a3ef34ca06a38630d5bb6 Gerrit-Change-Number: 24337 Gerrit-PatchSet: 8 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2026 18:51:13 +0000 Gerrit-HasComments: Yes
