Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24337 )
Change subject: IMPALA-14954: Support ADMIN OPTION clause for GRANT/REVOKE ROLE ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@172 PS8, Line 172: || params.getRequesting_user().equals(params.getGrant_user())); > Is this right that it's an admin op of requesting user equals grant user? I That case wouldn't be an admin op because params.getRequesting_user().equals(params.getGrant_user()) would evaluate to true which would get negated setting adminOp to false. http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/test/java/org/apache/impala/util/CatalogOpUtilTest.java File fe/src/test/java/org/apache/impala/util/CatalogOpUtilTest.java: http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/test/java/org/apache/impala/util/CatalogOpUtilTest.java@223 PS8, Line 223: "my_user", /* isGrantStmt */ true, /* hasAdminOpt */ false) Would it be beneficial to add tests where hasAdminOpt was set to true for both group and user? http://gerrit.cloudera.org:8080/#/c/24337/8/testdata/workloads/functional-query/queries/QueryTest/grant_revoke_admin_option.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke_admin_option.test: http://gerrit.cloudera.org:8080/#/c/24337/8/testdata/workloads/functional-query/queries/QueryTest/grant_revoke_admin_option.test@1 PS8, Line 1: ==== Please also add a test case where the user to granted a role and then a second statement grants the admin to that role, e.g.: create role role_03 grant role role_03 to $GRANTEE_TYPE $GRANTEE_NAME grant role role_03 to $GRANTEE_TYPE $GRANTEE_NAME with admin option -- To view, visit http://gerrit.cloudera.org:8080/24337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e7c9ba091bc15271c7a3ef34ca06a38630d5bb6 Gerrit-Change-Number: 24337 Gerrit-PatchSet: 8 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2026 21:35:28 +0000 Gerrit-HasComments: Yes
