Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24337 )
Change subject: IMPALA-14954: Support ADMIN OPTION clause for GRANT/REVOKE ROLE ...................................................................... Patch Set 9: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/test/java/org/apache/impala/util/CatalogOpUtilTest.java File fe/src/test/java/org/apache/impala/util/CatalogOpUtilTest.java: http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/test/java/org/apache/impala/util/CatalogOpUtilTest.java@223 PS8, Line 223: .toThrift(); > Yes. I will add tests where hasAdminOpt was set to true for both group and Done http://gerrit.cloudera.org:8080/#/c/24337/8/testdata/workloads/functional-query/queries/QueryTest/grant_revoke_admin_option.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke_admin_option.test: http://gerrit.cloudera.org:8080/#/c/24337/8/testdata/workloads/functional-query/queries/QueryTest/grant_revoke_admin_option.test@1 PS8, Line 1: ==== > Sure. I will add this test case in the next patch. Done -- To view, visit http://gerrit.cloudera.org:8080/24337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e7c9ba091bc15271c7a3ef34ca06a38630d5bb6 Gerrit-Change-Number: 24337 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 19:53:21 +0000 Gerrit-HasComments: Yes
