Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24337 )
Change subject: IMPALA-14954: Support ADMIN OPTION clause for GRANT/REVOKE ROLE ...................................................................... Patch Set 9: (5 comments) Hi all, I have addressed the comments on patch set 8 from Michael and Jason. Let me know if there are additional suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/main/java/org/apache/impala/analysis/ShowRolesPrincipalStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowRolesPrincipalStmt.java: http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/main/java/org/apache/impala/analysis/ShowRolesPrincipalStmt.java@40 PS8, Line 40: Preconditions.checkArgument(principalType == TPrincipalType.USER || > nit: checkArgument would be more appropriate. Yes, I will change it to checkArgument in the next patch. http://gerrit.cloudera.org:8080/#/c/24337/7/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/24337/7/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@22 PS7, Line 22: import org.apache.hadoop.hive.metastore.api.PrincipalType; > unused import: com.google.common.collect.Sets Done http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@172 PS8, Line 172: || params.getRequesting_user().equals(params.getGrant_user())); > Oh, missed the negation is outside the parentheses. Thanks! Yes, what Jason said matches my understanding. http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/test/java/org/apache/impala/util/CatalogOpUtilTest.java File fe/src/test/java/org/apache/impala/util/CatalogOpUtilTest.java: http://gerrit.cloudera.org:8080/#/c/24337/8/fe/src/test/java/org/apache/impala/util/CatalogOpUtilTest.java@223 PS8, Line 223: .toThrift(); > Would it be beneficial to add tests where hasAdminOpt was set to true for b Yes. I will add tests where hasAdminOpt was set to true for both group and user in the next patch. http://gerrit.cloudera.org:8080/#/c/24337/8/testdata/workloads/functional-query/queries/QueryTest/grant_revoke_admin_option.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke_admin_option.test: http://gerrit.cloudera.org:8080/#/c/24337/8/testdata/workloads/functional-query/queries/QueryTest/grant_revoke_admin_option.test@1 PS8, Line 1: ==== > Please also add a test case where the user to granted a role and then a sec Sure. I will add this test case in the next patch. -- To view, visit http://gerrit.cloudera.org:8080/24337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e7c9ba091bc15271c7a3ef34ca06a38630d5bb6 Gerrit-Change-Number: 24337 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 01:29:19 +0000 Gerrit-HasComments: Yes
