Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24337 )
Change subject: IMPALA-14954: Support ADMIN OPTION clause for GRANT/REVOKE ROLE ...................................................................... Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/24337/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/24337/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@147 PS9, Line 147: LOG.error("Error executing SHOW ROLES."); Not related, but I'm not sure why the exception e is omitted here. http://gerrit.cloudera.org:8080/#/c/24337/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@205 PS9, Line 205: LOG.error("Error executing SHOW ROLE GRANT GROUP " + params.getGrant_group() + Would be better to use slf4j substitution here. Should we also include the exception, like LOG.error("Error executing SHOW CURRENT ROLES.", e); does? http://gerrit.cloudera.org:8080/#/c/24337/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@210 PS9, Line 210: LOG.error("Error executing SHOW ROLE GRANT USER " + params.getGrant_user() + And here. http://gerrit.cloudera.org:8080/#/c/24337/9/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/24337/9/fe/src/main/java/org/apache/impala/service/Frontend.java@896 PS9, Line 896: new TColumn("role_name", Type.STRING.toThrift()))); Are you specifically omitting grant_option here? http://gerrit.cloudera.org:8080/#/c/24337/9/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/24337/9/tests/authorization/test_ranger.py@2461 PS9, Line 2461: # Verify that the user 'getuser()' is associated with the role 'r_2'. Can we add a test trying to SHOW ROLE GRANT USER for a different user as a non-admin? -- To view, visit http://gerrit.cloudera.org:8080/24337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e7c9ba091bc15271c7a3ef34ca06a38630d5bb6 Gerrit-Change-Number: 24337 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 21:59:04 +0000 Gerrit-HasComments: Yes
