Nandor Kollar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24166 )
Change subject: IMPALA-14684: Add metrics for catalogd table invalidations ...................................................................... Patch Set 9: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24166/9/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java: http://gerrit.cloudera.org:8080/#/c/24166/9/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@120 PS9, Line 120: private final AtomicLong lastTtlInvalidationMillis_ = new AtomicLong(0); nit: You might consider saving the last batch, instead of two distinct variable for the count ant the timestamp Furthermore, AtomicLong seems unnecessary complication here, as reading/writing of these variable is done within synchronized blocks. -- To view, visit http://gerrit.cloudera.org:8080/24166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If78e6c8429801e3c1829860666f04ad287b826ab Gerrit-Change-Number: 24166 Gerrit-PatchSet: 9 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 29 Jul 2026 15:09:23 +0000 Gerrit-HasComments: Yes
