Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24166 )
Change subject: IMPALA-14684: Add metrics for catalogd table invalidations ...................................................................... Patch Set 9: (4 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24166/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java: http://gerrit.cloudera.org:8080/#/c/24166/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@110 PS8, Line 110: > nit: Probably record type could make this more concise? Done. (However, Impala doesnt use records in the codebase). http://gerrit.cloudera.org:8080/#/c/24166/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@323 PS8, Line 323: lastMemoryPressureInvalidationMillis_.set(System.currentTimeMillis()); > Since this method operates on the batches queue, it might be better to sync Right, it'd the better solution than using a read-write lock since there's no need for modifications to the dequeues to be mutually exclusive and we can synchronize them individually. Metrics refresh no longer waits on catalog scans, it only waits on brief per-deque updates. http://gerrit.cloudera.org:8080/#/c/24166/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@352 PS8, Line 352: long ttlInvalidations1Min, > nit: Probably record type could make this more concise? Done http://gerrit.cloudera.org:8080/#/c/24166/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@391 PS8, Line 391: long memoryPressureInvalidations30Min; > Since this method doesn't modify any state, would it make sense to use a re Yes, and we are now synchronizing on the dequeues individually instead of the invalidator obj. getMetrics() no longer blocks on catalog scans but only for a brief moment when the dequeues update. -- To view, visit http://gerrit.cloudera.org:8080/24166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If78e6c8429801e3c1829860666f04ad287b826ab Gerrit-Change-Number: 24166 Gerrit-PatchSet: 9 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 23 Jul 2026 11:53:44 +0000 Gerrit-HasComments: Yes
