Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER ...................................................................... Patch Set 7: (3 comments) mostly nits, otherwise looks good. http://gerrit.cloudera.org:8080/#/c/10822/7/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/10822/7/fe/src/main/cup/sql-parser.cup@1136 PS7, Line 1136: ident_or_default:user nit: move to prev. line http://gerrit.cloudera.org:8080/#/c/10822/7/fe/src/main/cup/sql-parser.cup@1138 PS7, Line 1138: // The Same comment as on L1107. Please factor the comment to top L1057 and refer to it from these three places as "See above for special partition clause handling". http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py File tests/metadata/test_ddl_base.py: http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py@96 PS7, Line 96: _get_property is this general purpose? should this be used when there are multiple rows per section? -- To view, visit http://gerrit.cloudera.org:8080/10822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1 Gerrit-Change-Number: 10822 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 06 Jul 2018 20:53:40 +0000 Gerrit-HasComments: Yes
