Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/10822/7/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/10822/7/fe/src/main/cup/sql-parser.cup@1136 PS7, Line 1136: IDENT:user_id ident_or_default:user > nit: move to prev. line Done http://gerrit.cloudera.org:8080/#/c/10822/7/fe/src/main/cup/sql-parser.cup@1138 PS7, Line 1138: // See > Same comment as on L1107. Please factor the comment to top L1057 and refer Done http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py File tests/metadata/test_ddl_base.py: http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py@96 PS7, Line 96: _get_property > is this general purpose? should this be used when there are multiple rows p Yes, it's generic enough to get a single property value. The format is consistent for multiple row values vs single row value. It should not be used for multiple rows though. -- To view, visit http://gerrit.cloudera.org:8080/10822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1 Gerrit-Change-Number: 10822 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 06 Jul 2018 21:14:09 +0000 Gerrit-HasComments: Yes
