Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24656 )
Change subject: IMPALA-15238: Add TPC-DS planner tests with CTE suggestions enabled ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/24656/5/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java: http://gerrit.cloudera.org:8080/#/c/24656/5/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java@164 PS5, Line 164: public static void unsetMetadataScaleAndStopPoolService() { Both this class and TpcdsCpuCostPlannerTest start the same RequestPoolService singleton, but neither Calcite test stops it. Surefire reuses one JVM for the module, and start() rejects an already running instance, so whichever class runs second should fail in @BeforeClass. Could we stop/reset the service in both classes, as the FE test already does? http://gerrit.cloudera.org:8080/#/c/24656/5/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java@188 PS5, Line 188: for (int i = 1; i <= 99; i++) { This numeric loop silently drops the second official variants of Q14, Q23, and Q24. TpcdsCpuCostPlannerTest covers both a/b variants, while this suite includes only the a queries under unsuffixed names. Could we add the three b variants to the parameters and goldens? -- To view, visit http://gerrit.cloudera.org:8080/24656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdf22c054d94e35ccbd9edae89ce8e1606194155 Gerrit-Change-Number: 24656 Gerrit-PatchSet: 5 Gerrit-Owner: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 10 Aug 2026 10:03:16 +0000 Gerrit-HasComments: Yes
