Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24656 )
Change subject: IMPALA-15238: Add TPC-DS planner tests with CTE suggestions enabled ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/24656/5/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java: http://gerrit.cloudera.org:8080/#/c/24656/5/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java@53 PS5, Line 53: * DISTRIBUTED and PARALLEL plans do not yet support CTEs. > This last sentence is outdated. I'm going to address this in the next patch since DISTRIBUTED/PARALLEL plans required some fixes in CPU costing. http://gerrit.cloudera.org:8080/#/c/24656/5/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java@164 PS5, Line 164: public static void unsetMetadataScaleAndStopPoolService() { > Both this class and TpcdsCpuCostPlannerTest start the same RequestPoolServi Done -- To view, visit http://gerrit.cloudera.org:8080/24656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdf22c054d94e35ccbd9edae89ce8e1606194155 Gerrit-Change-Number: 24656 Gerrit-PatchSet: 7 Gerrit-Owner: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 13 Aug 2026 20:11:53 +0000 Gerrit-HasComments: Yes
