Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24656 )
Change subject: IMPALA-15238: Add TPC-DS planner tests with CTE suggestions enabled ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/24656/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/24656/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@392 PS11, Line 392: // the end user. > Comparator.comparing() re-evaluates its key function on every comparison, s Done http://gerrit.cloudera.org:8080/#/c/24656/11/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java: http://gerrit.cloudera.org:8080/#/c/24656/11/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java@51 PS11, Line 51: * copy of {@link org.apache.impala.calcite.planner.TpcdsCpuCostPlannerTest} with few > Small one: the {@link} points at the FE class org.apache.impala.planner.Tpc Done -- To view, visit http://gerrit.cloudera.org:8080/24656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdf22c054d94e35ccbd9edae89ce8e1606194155 Gerrit-Change-Number: 24656 Gerrit-PatchSet: 12 Gerrit-Owner: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 16:56:41 +0000 Gerrit-HasComments: Yes
