Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24656 )
Change subject: IMPALA-15238: Add TPC-DS planner tests with CTE suggestions enabled ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/24656/5/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java: http://gerrit.cloudera.org:8080/#/c/24656/5/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java@164 PS5, Line 164: public static void unsetMetadataScaleAndStopPoolService() { > Done Checked on PS11: stop() also clears the singleton ("unset single_instance_ if this RequestPoolService is the singleton"), so whichever class runs second builds a fresh instance and its start() precondition holds. Both Calcite tests now do the same as the FE one. http://gerrit.cloudera.org:8080/#/c/24656/5/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCtePlannerTest.java@188 PS5, Line 188: for (int i = 1; i <= 99; i++) { > Done q14b/q23b/q24b are there - 101 golden files, which matches 99 - q39 - 3 + 6. And when IMPALA-15243 is fixed, q39 can come back as List.of("q39a", "q39b"): the other TPC-DS suites carry it as a/b variants too. -- To view, visit http://gerrit.cloudera.org:8080/24656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdf22c054d94e35ccbd9edae89ce8e1606194155 Gerrit-Change-Number: 24656 Gerrit-PatchSet: 5 Gerrit-Owner: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 10:23:44 +0000 Gerrit-HasComments: Yes
