Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24657 )
Change subject: IMPALA-13534: Implement runtime filters on CTEs ...................................................................... Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/24657/13/be/src/exec/cte-consumer-node.cc File be/src/exec/cte-consumer-node.cc: http://gerrit.cloudera.org:8080/#/c/24657/13/be/src/exec/cte-consumer-node.cc@260 PS13, Line 260: FilterRowBatch(output_batch); > In the non-passthrough path this runs after MaterializeBatch(), so rows the There's a bit of a trade-off here. We might be able to do most of the required copying while waiting for the runtime filters to arrive, then fix up the results. There's an optimal path where we copy rows and periodically check for runtime filter arrival, then once they've arrived we apply them to prior rows and handle them inline for the remainder. I'm going to explore that implementation. http://gerrit.cloudera.org:8080/#/c/24657/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/24657/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@997 PS13, Line 997: arrangeRuntimeFilters(childNode); > Now that this always recurses into the children, it descends into the CTE p I think the cost is small enough to ignore. http://gerrit.cloudera.org:8080/#/c/24657/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@1480 PS13, Line 1480: if (filter.getType() == TRuntimeFilterType.MIN_MAX && !enable_overlap_filter) { > enableOverlapFilter() describes Parquet overlap pruning: it reads parquet_r I'm not sure this skip makes sense. -- To view, visit http://gerrit.cloudera.org:8080/24657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic877fb590187826f828da6a27bf274465c381e8e Gerrit-Change-Number: 24657 Gerrit-PatchSet: 16 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 20:18:17 +0000 Gerrit-HasComments: Yes
