Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24657 )
Change subject: IMPALA-13534: Implement runtime filters on CTEs ...................................................................... Patch Set 17: Code-Review+1 +1, and thanks for turning all of these around so quickly. The goldens staying untouched in PS17 makes sense - with both minmax options defaulting to true, the skip only ever bit when parquet statistics were off. I also read the backend properly this time rather than skimming it, and have no further questions. One note for whenever you pick up the materialization experiment: LocalExchanger::Push() never blocks, so while a consumer sits in WaitForRuntimeFilters the producer keeps appending cells. Doesn't matter today, might matter for a version that copies while waiting. -- To view, visit http://gerrit.cloudera.org:8080/24657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic877fb590187826f828da6a27bf274465c381e8e Gerrit-Change-Number: 24657 Gerrit-PatchSet: 17 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 20:47:07 +0000 Gerrit-HasComments: No
