Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24657 )
Change subject: IMPALA-13534: Implement runtime filters on CTEs ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/24657/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/24657/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@1480 PS13, Line 1480: if (filter.getType() == TRuntimeFilterType.MIN_MAX && !enable_overlap_filter) { > I'm not sure this skip makes sense. Same feeling here. The scan path gates min/max on enableOverlapFilter() because on an HdfsScanNode the filter is only usable as an overlap predicate over Parquet statistics - hence the tryToComputeOverlapPredicate() check right after it - while the Kudu branch never looks at that flag. A CTE consumer has no such limitation: it evaluates min/max row by row through FilterContext::Eval() over batches from the LocalExchanger, so the question isn't whether the filter can be applied, only whether it earns its keep. And the runtime already answers that: CheckFiltersEffectiveness() runs every 16 batches and clears enabled_for_row once a filter is always-true or its reject ratio falls under min_filter_reject_ratio (0.1 by default). So the extra min/max entries Joe noticed cost a handful of batches rather than the whole read. Dropping the condition here looks closest to what the node actually does. If you'd rather stay conservative for now, gating on enabled_runtime_filter_types would at least tie it to something that applies to this node. -- To view, visit http://gerrit.cloudera.org:8080/24657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic877fb590187826f828da6a27bf274465c381e8e Gerrit-Change-Number: 24657 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 20:38:49 +0000 Gerrit-HasComments: Yes
