Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24657 )
Change subject: IMPALA-13534: Implement runtime filters on CTEs ...................................................................... Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/24657/13/be/src/exec/cte-consumer-node.cc File be/src/exec/cte-consumer-node.cc: http://gerrit.cloudera.org:8080/#/c/24657/13/be/src/exec/cte-consumer-node.cc@260 PS13, Line 260: FilterRowBatch(output_batch); > There's a bit of a trade-off here. We might be able to do most of the requi I don't think I can get an meaningful improvement in memory access patterns by moving filtering earlier. We filter based on the materialized row, so can't skip materialization, and passthrough bulk copying is pretty efficient. There's possibly still room for improvement, but it'd be a large change so I'd rather leave it as a follow-up experiment. -- To view, visit http://gerrit.cloudera.org:8080/24657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic877fb590187826f828da6a27bf274465c381e8e Gerrit-Change-Number: 24657 Gerrit-PatchSet: 16 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 20:36:13 +0000 Gerrit-HasComments: Yes
