Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24717 )

Change subject: IMPALA-15277: Address test failures related 
MetastoreEventsProcessorTest
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24717/5/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
File 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java:

http://gerrit.cloudera.org:8080/#/c/24717/5/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3764
PS5, Line 3764: // ADD_PARTITION, ALTER_PARTITION, ALTER_PARTITION
nit: please update the comments on L3751-3759. Maybe also mention the Hive 
versions/JIRAs.


http://gerrit.cloudera.org:8080/#/c/24717/5/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3959
PS5, Line 3959:         "COMMIT_COMPACTION_EVENT.", foundCommitCompaction);
nit: can we print the events if this fails?



--
To view, visit http://gerrit.cloudera.org:8080/24717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30d810609fccaac73a0eb4e3f2e257521a3da10f
Gerrit-Change-Number: 24717
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Sat, 22 Aug 2026 02:03:38 +0000
Gerrit-HasComments: Yes

Reply via email to