Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24506
to look at the new patch set (#5).
Change subject: IMPALA-15201: Enable comparison operators and predicates for
UUID type
......................................................................
IMPALA-15201: Enable comparison operators and predicates for UUID type
Add support for comparison operators (=, !=, <, >, <=, >=) and
predicates (IN, NOT IN, IS NULL, IS NOT NULL, BETWEEN) on UUID columns
in Iceberg tables. Implements minimal implicit STRING->UUID casting for
predicate literal promotion only, while blocking implicit UUID->STRING
conversion to prevent unintended type coercion.
Backend changes:
- Add UUID comparison operators using memcmp on 16-byte canonical
representation
- Implement CastToUuid with runtime validation and error reporting for
invalid UUID string literals
- Add UUID literal parsing with canonical UUID string format
Frontend changes:
- Remove UUID guards from BinaryPredicate, InPredicate, IsNullPredicate
- Configure UuidCompatibility matrix to allow only STRING->UUID promotion
- Register CAST_TO_UUID_FN for implicit predicate literal conversion
- Block explicit UUID->STRING casts (deferred to IMPALA-15202)
Testing:
- Add positive tests for range, IN, NOT IN, BETWEEN predicates
- Add negative test for length(uuid_col) to verify no implicit
UUID->STRING
- Add negative test for invalid UUID literals to verify runtime
parse errors
Change-Id: I0e8c4c631ccc25a5f2da3540c2d18cf9dba79fe9
Assisted-by: Composer 2.5
---
M be/src/exprs/cast-functions-ir.cc
M be/src/exprs/cast-functions.h
M be/src/exprs/literal.cc
M be/src/exprs/operators-ir.cc
M be/src/exprs/operators.h
M fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M fe/src/main/java/org/apache/impala/analysis/InPredicate.java
M fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java
M fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java
M fe/src/main/java/org/apache/impala/analysis/StringLiteral.java
M fe/src/main/java/org/apache/impala/catalog/UuidCompatibility.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test
13 files changed, 198 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/24506/5
--
To view, visit http://gerrit.cloudera.org:8080/24506
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0e8c4c631ccc25a5f2da3540c2d18cf9dba79fe9
Gerrit-Change-Number: 24506
Gerrit-PatchSet: 5
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
