Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24506 )
Change subject: IMPALA-15201: Enable comparison operators and predicates for UUID type ...................................................................... Patch Set 7: (2 comments) Ive removed implicit casts for string -> uuid and had to use a little roundabout way for testing the other predicates. We can simplify those once we add explicit casts. http://gerrit.cloudera.org:8080/#/c/24506/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24506/6//COMMIT_MSG@11 PS6, Line 11: dCompatibility blocks all imp > I think we should start with explicit CAST support only, later we can think Done. Ive removed cast support as we're going to add it as part of IMPALA-15202 and filed IMPALA-15328 for adding UUID typed literals. http://gerrit.cloudera.org:8080/#/c/24506/6/fe/src/main/java/org/apache/impala/analysis/CastExpr.java File fe/src/main/java/org/apache/impala/analysis/CastExpr.java: http://gerrit.cloudera.org:8080/#/c/24506/6/fe/src/main/java/org/apache/impala/analysis/CastExpr.java@394 PS6, Line 394: if (fn_ == null) { : throw new AnalysisException("Invalid type cast of " + getChild(0).toSql() + : " from " + childType + " to " + type_); : } : > I think we should first allow explicit CASTs from STRING to UUID, then we c Sure, Ive removed both sides (UUID <-> STRING) of cast support. We'll add that as part of IMPALA-15202. -- To view, visit http://gerrit.cloudera.org:8080/24506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e8c4c631ccc25a5f2da3540c2d18cf9dba79fe9 Gerrit-Change-Number: 24506 Gerrit-PatchSet: 7 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 03 Sep 2026 11:12:11 +0000 Gerrit-HasComments: Yes
