Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24506
to look at the new patch set (#7).
Change subject: IMPALA-15201: Enable comparison operators and predicates for
UUID type
......................................................................
IMPALA-15201: Enable comparison operators and predicates for UUID type
Add support for comparison operators (=, !=, <, >, <=, >=) and
predicates (IN, NOT IN, IS NULL, IS NOT NULL, BETWEEN) on UUID
columns in Iceberg tables. UuidCompatibility blocks all implicit
casts between UUID and other types, so predicates must use UUID-typed
expressions (e.g. column references or scalar subqueries) rather than
string literals.
Backend changes:
- Add UUID comparison operators using memcmp on 16-byte canonical
representation
- Comparison uses RFC 4122 byte ordering
Frontend changes:
- Remove UUID guards from BinaryPredicate, InPredicate, IsNullPredicate
- Keep UuidCompatibility blocking both STRING->UUID and UUID->STRING
implicit promotion
- Block explicit UUID<->STRING casts (deferred to IMPALA-15202)
Enables ORDER BY, GROUP BY, and JOIN on UUID columns in addition to
comparison predicates.
Testing:
- Add positive tests for =, !=, range, IN, NOT IN, BETWEEN, JOIN, and
null checks using scalar subqueries to supply UUID-typed values
- Add negative tests confirming string literals are rejected in
predicates and explicit casts remain blocked
Change-Id: I0e8c4c631ccc25a5f2da3540c2d18cf9dba79fe9
Assisted-by: Composer 2.5
---
M be/src/exprs/operators-ir.cc
M be/src/exprs/operators.h
M fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java
M fe/src/main/java/org/apache/impala/analysis/InPredicate.java
M fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test
6 files changed, 155 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/24506/7
--
To view, visit http://gerrit.cloudera.org:8080/24506
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0e8c4c631ccc25a5f2da3540c2d18cf9dba79fe9
Gerrit-Change-Number: 24506
Gerrit-PatchSet: 7
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
