Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24590 )
Change subject: IMPALA-9821: Change DataSketches functions to return BINARY ...................................................................... Patch Set 5: Code-Review+1 (3 comments) lgtm, only minor things http://gerrit.cloudera.org:8080/#/c/24590/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24590/3//COMMIT_MSG@9 PS3, Line 9: Currently Impala returns a STRING value for > While the change is global, the type discrepancy was resulting in error onl I am still a bit confused about the ORC story. Is it about datasketches specifically, or BINARY columns in general? I think that adding some historical notes is useful to get the big picture about this change: DataSketches functions were added before BINARY type support (IMPALA-9482), leading to the current STRING based solution, which is incompatible with other systems (like Hive). After adding BINARY, the changing of signatures (IMPALA-9821) was delayed, waiting for a major version, because it is not a backward compatible. Now it is added in preparation for Impala 5.0. http://gerrit.cloudera.org:8080/#/c/24590/5/testdata/workloads/functional-query/queries/QueryTest/datasketches-cpc.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-cpc.test: http://gerrit.cloudera.org:8080/#/c/24590/5/testdata/workloads/functional-query/queries/QueryTest/datasketches-cpc.test@222 PS5, Line 222: ---- QUERY : # Check that ds_cpc_union rejects STRING sketch inputs. : select ds_cpc_union(date_string_col) from functional_parquet.alltypestiny where id=1; : ---- CATCH : AnalysisException: No matching function with signature: ds_cpc_union(STRING) Probably there is no need to keep all STRING tests. http://gerrit.cloudera.org:8080/#/c/24590/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test: http://gerrit.cloudera.org:8080/#/c/24590/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test@5 PS3, Line 5: ections > It doesn't seem to be the case for HIVE_QUERY's. Removed for regular ones t good point, probably the hive client could be changed, but it is out of scope for this review -- To view, visit http://gerrit.cloudera.org:8080/24590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4a6b54089dd356e37257bc24adeb1eb98e82c25 Gerrit-Change-Number: 24590 Gerrit-PatchSet: 5 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 17 Sep 2026 12:06:43 +0000 Gerrit-HasComments: Yes
