Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24590 )
Change subject: IMPALA-9821: Change DataSketches functions to return BINARY ...................................................................... Patch Set 8: Code-Review+1 (1 comment) lgtm, but I still think that the ORC part is confusing http://gerrit.cloudera.org:8080/#/c/24590/6/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test: http://gerrit.cloudera.org:8080/#/c/24590/6/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test@16 PS6, Line 16: 9482 > EDIT (Fixed typos): I still think that this is a bit confusing and not the main focus of the change. >From the jira: "Currently when sketches are written by Hive as BINARY to ORC table and this table is loaded to Impala where the sketch columns are STRINGs then we get an error" The table was written as BINARY but read as STRING, so there was a schema change (but not in this test), leading to allowing the read (before IMPALA-9482) and the read fails as it is expecting string but seeing binary in the ORC file. With IMPALA-9482 both the original schema can be kept (BINARY allowed) and the binary columns in ORC can be read as both STRING and BINARY. -- To view, visit http://gerrit.cloudera.org:8080/24590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4a6b54089dd356e37257bc24adeb1eb98e82c25 Gerrit-Change-Number: 24590 Gerrit-PatchSet: 8 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 18 Sep 2026 15:49:58 +0000 Gerrit-HasComments: Yes
