Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24590 )
Change subject: IMPALA-9821: Change DataSketches functions to return BINARY ...................................................................... Patch Set 6: (3 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/24590/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24590/6//COMMIT_MSG@13 PS6, Line 13: because it is not a backward compatible Please add notes to docs/topics/impala_incompatible_changes.xml http://gerrit.cloudera.org:8080/#/c/24590/6//COMMIT_MSG@55 PS6, Line 55: Migrate by storing : sketches in BINARY columns Maybe an ALTER TABLE CHANGE COLUMN can be enough. http://gerrit.cloudera.org:8080/#/c/24590/6/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: http://gerrit.cloudera.org:8080/#/c/24590/6/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@1132 PS6, Line 1132: Type.STRING Is this intentionally Type.STRING? Because of this AggregateFunction's intermediateType_ is not null: https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/catalog/AggregateFunction.java#L42 AFAICT this can cause runtime consequences as now the aggregates get intermediate tuples. Type.BINARY, Type.BINARY would keep the old single-tuple plan. -- To view, visit http://gerrit.cloudera.org:8080/24590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4a6b54089dd356e37257bc24adeb1eb98e82c25 Gerrit-Change-Number: 24590 Gerrit-PatchSet: 6 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 17 Sep 2026 16:48:09 +0000 Gerrit-HasComments: Yes
