Hello Quanlong Huang, Arnab Karmakar, Michael Smith, Joe McDonnell, Csaba
Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24422
to look at the new patch set (#11).
Change subject: IMPALA-15081: Text time filters in profile tool
......................................................................
IMPALA-15081: Text time filters in profile tool
Add --min_time and --max_time to impala-profile-tool as text
alternatives to the existing Unix epoch millisecond filters. The
shorter names distinguish text input from --min_timestamp and
--max_timestamp; mixing the two forms is rejected.
Accept ISO-8601 extended date/time (RFC 3339 style), with seconds
and an optional fraction of up to nine digits. A timezone is required:
Z or a numeric offset in +HH:MM, +HHMM or +HH form. Named timezones
are not accepted. Examples:
--min_time=2026-08-03T01:54:55.212Z
--min_time=2026-08-03T07:24:55.212+05:30
--max_time=2026-08-02T23:54:55.212-0200
Use absl::ParseTime for calendar and offset conversion, with syntax
validation for the supported input forms. Round lower bounds up and
upper bounds down for inclusive filtering at millisecond precision,
including timestamps before the epoch.
Add regression coverage for offset boundaries, malformed timestamps,
both text flags, sub-millisecond rounding and mixed filter forms.
Change-Id: I2c43e7535db48518b7d9dd0cbb87398e639c3b72
---
M be/src/util/CMakeLists.txt
M be/src/util/impala-profile-tool.cc
M tests/observability/test_profile_tool.py
3 files changed, 250 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/24422/11
--
To view, visit http://gerrit.cloudera.org:8080/24422
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c43e7535db48518b7d9dd0cbb87398e639c3b72
Gerrit-Change-Number: 24422
Gerrit-PatchSet: 11
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
