Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24422 )
Change subject: IMPALA-15081: Text time filters in profile tool ...................................................................... Patch Set 11: (7 comments) http://gerrit.cloudera.org:8080/#/c/24422/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24422/10//COMMIT_MSG@7 PS10, Line 7: IMPALA-15081: Text time filters in profile tool > Updated in PS11. The subject now names profile tool; the description says I Done http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc@22 PS11, Line 22: #include <exception> nit: not needed http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc@36 PS11, Line 36: #include "gutil/walltime.h" nit: not needed http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc@104 PS11, Line 104: using boost::posix_time::from_iso_extended_string; nit: unused http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc@656 PS11, Line 656: // ToUnixMillis() rounds down, including before the epoch. Round lower bounds : // up to preserve inclusive comparisons with millisecond profile log entries. The comment makes it sound like both MIN and MAX timestamps are being adjusted, but the code only adjusts MIN. This is probably correct because MIN needs to be rounded up, while MAX can safely stay rounded down. I think it would be good to add a short line that tells why MAX doesn't need adjustment. http://gerrit.cloudera.org:8080/#/c/24422/10/tests/observability/test_profile_tool.py File tests/observability/test_profile_tool.py: http://gerrit.cloudera.org:8080/#/c/24422/10/tests/observability/test_profile_tool.py@156 PS10, Line 156: test_iso8601_timestamp_filter > Updated in PS11. Offsets are tested at first+1 ms against --min_timestamp, Done http://gerrit.cloudera.org:8080/#/c/24422/10/tests/observability/test_profile_tool.py@218 PS10, Line 218: '2026-06-08T12Z', > Added invalid-input checks for --max_time in PS11, including its name in th Done -- To view, visit http://gerrit.cloudera.org:8080/24422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c43e7535db48518b7d9dd0cbb87398e639c3b72 Gerrit-Change-Number: 24422 Gerrit-PatchSet: 11 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 05 Oct 2026 10:29:45 +0000 Gerrit-HasComments: Yes
