Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24422 )
Change subject: IMPALA-15081: Text time filters in profile tool ...................................................................... Patch Set 12: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc@22 PS11, Line 22: #include <iostream> > Removed the unused include in PS12. Done http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc@36 PS11, Line 36: #include "util/parse-util.h > Removed the unused include in PS12. Done http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc@104 PS11, Line 104: using std::cerr; > Removed the unused using declaration in PS12. Done http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc@656 PS11, Line 656: *unix_time_millis = absl::ToUnixMillis(utc_time); : if (bound == TimeFilterBound::MIN > Clarified in PS12: MIN rounds up to exclude entries below the bound; MAX st Done -- To view, visit http://gerrit.cloudera.org:8080/24422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c43e7535db48518b7d9dd0cbb87398e639c3b72 Gerrit-Change-Number: 24422 Gerrit-PatchSet: 12 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 05 Oct 2026 12:44:41 +0000 Gerrit-HasComments: Yes
