Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24422 )
Change subject: IMPALA-15081: Text time filters in profile tool ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc@22 PS11, Line 22: #include <exception> > nit: not needed Removed the unused include in PS12. http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc@36 PS11, Line 36: #include "gutil/walltime.h" > nit: not needed Removed the unused include in PS12. http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc@104 PS11, Line 104: using boost::posix_time::from_iso_extended_string; > nit: unused Removed the unused using declaration in PS12. http://gerrit.cloudera.org:8080/#/c/24422/11/be/src/util/impala-profile-tool.cc@656 PS11, Line 656: // ToUnixMillis() rounds down, including before the epoch. Round lower bounds : // up to preserve inclusive comparisons with millisecond profile log entries. > The comment makes it sound like both MIN and MAX timestamps are being adjus Clarified in PS12: MIN rounds up to exclude entries below the bound; MAX stays rounded down because profile timestamps are integer milliseconds. -- To view, visit http://gerrit.cloudera.org:8080/24422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c43e7535db48518b7d9dd0cbb87398e639c3b72 Gerrit-Change-Number: 24422 Gerrit-PatchSet: 11 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 05 Oct 2026 12:13:08 +0000 Gerrit-HasComments: Yes
