Le Minh Nghia has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 )
Change subject: IMPALA-6490: Reconnect shell when remote restarts ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/10992/5/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/10992/5/shell/impala_shell.py@616 PS5, Line 616: self.prompt = ImpalaShell.PROMPT_FORMAT.format(host=self.impalad[0], : port=self.impalad[1], : db=current_db) > As every invocation is used to set self.prompt, the assignment could be mov Done http://gerrit.cloudera.org:8080/#/c/10992/6/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/10992/6/shell/impala_shell.py@581 PS6, Line 581: # TODO: This may have to be changed to a super() call once we move to Python 3 : if line == None: : return CmdStatus.ERROR : else: : # This code is based on the code from the standar > Are you sure that this is needed? You're right, I don't need this anymore. :) http://gerrit.cloudera.org:8080/#/c/10992/6/tests/custom_cluster/test_shell_interactive_reconnect.py File tests/custom_cluster/test_shell_interactive_reconnect.py: http://gerrit.cloudera.org:8080/#/c/10992/6/tests/custom_cluster/test_shell_interactive_reconnect.py@87 PS6, Line 87: proc.sendline("use tpch;") > This could go to an outer scope as both more than one tests use it. Done http://gerrit.cloudera.org:8080/#/c/10992/6/tests/custom_cluster/test_shell_interactive_reconnect.py@92 PS6, Line 92: > This is not needed if you are using the default port. I know, I just put it there for sure. http://gerrit.cloudera.org:8080/#/c/10992/6/tests/custom_cluster/test_shell_interactive_reconnect.py@108 PS6, Line 108: : > Do you want to keep these? I think these were added as a temporary solution Done -- To view, visit http://gerrit.cloudera.org:8080/10992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia13365a9696886f01294e98054cf4e7cd66ab712 Gerrit-Change-Number: 10992 Gerrit-PatchSet: 5 Gerrit-Owner: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 31 Jul 2018 08:24:15 +0000 Gerrit-HasComments: Yes
