Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 )
Change subject: IMPALA-6490: Reconnect shell when remote restarts ...................................................................... Patch Set 7: (2 comments) Looks good, only found some nit comments. After fixing those I can give it +2. http://gerrit.cloudera.org:8080/#/c/10992/7/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/10992/7/shell/impala_shell.py@859 PS7, Line 859: return nit: I think you'll need to write it in the next line because PEP8 won't like it: https://www.python.org/dev/peps/pep-0008/#other-recommendations "Compound statements (multiple statements on the same line) are generally discouraged" http://gerrit.cloudera.org:8080/#/c/10992/7/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/10992/7/tests/common/custom_cluster_test_suite.py@159 PS7, Line 159: if "--kill" in options: : return I think it is not needed anymore because this method is only used for starting an impala cluster. -- To view, visit http://gerrit.cloudera.org:8080/10992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia13365a9696886f01294e98054cf4e7cd66ab712 Gerrit-Change-Number: 10992 Gerrit-PatchSet: 7 Gerrit-Owner: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Le Minh Nghia <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 31 Jul 2018 15:54:40 +0000 Gerrit-HasComments: Yes
