Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11181 )

Change subject: IMPALA-7421. Static methods use wrong JNI call function
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11181/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11181/2//COMMIT_MSG@12
PS2, Line 12: -Xcheck:jni
> Ah, that wasn't the one I had noted. The one I saw was something from the J
Oh I see, I didn't see those warnings about network interfaces in my local 
setup.


http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/util/jni-util.h
File be/src/util/jni-util.h:

http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/util/jni-util.h@273
PS2, Line 273: ObjectToResult
> I think we use this in most places Status is involved. There is a TODO abou
Digging into this, more information in IMPALA-2615 and
https://gerrit.cloudera.org/#/c/7253/



--
To view, visit http://gerrit.cloudera.org:8080/11181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7cde6ca91613b63afe5307f4d819fb24cb17fd6
Gerrit-Change-Number: 11181
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Tue, 14 Aug 2018 06:29:09 +0000
Gerrit-HasComments: Yes

Reply via email to