Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 )
Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/11235/5/lib/python/impala_py_lib/jenkins/generate_junitxml.py File lib/python/impala_py_lib/jenkins/generate_junitxml.py: http://gerrit.cloudera.org:8080/#/c/11235/5/lib/python/impala_py_lib/jenkins/generate_junitxml.py@39 PS5, Line 39: e flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/11235/5/lib/python/impala_py_lib/jenkins/generate_junitxml.py@48 PS5, Line 48: def xml(phase, step, error_msg, stdout, stderr, elapsed_time): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/11235/5/lib/python/impala_py_lib/jenkins/generate_junitxml.py@63 PS5, Line 63: def get_content(file_or_string=None): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/11235/5/lib/python/impala_py_lib/jenkins/generate_junitxml.py@153 PS5, Line 153: ' flake8: E501 line too long (93 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/11235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I958ee0d8420b6a4197aaf0a7e0538a566332ea97 Gerrit-Change-Number: 11235 Gerrit-PatchSet: 5 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Nithya Janarthanan <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Thu, 16 Aug 2018 00:20:13 +0000 Gerrit-HasComments: Yes
