David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 )
Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/11235/4/lib/python/impala_py_lib/jenkins/generate_junitxml.py File lib/python/impala_py_lib/jenkins/generate_junitxml.py: http://gerrit.cloudera.org:8080/#/c/11235/4/lib/python/impala_py_lib/jenkins/generate_junitxml.py@38 PS4, Line 38: <testsuite disabled="0" errors="{errors}" failures="0" file="None" log="None" > I'll wait for your reply as to whether or not to do away with the class. Done http://gerrit.cloudera.org:8080/#/c/11235/4/lib/python/impala_py_lib/jenkins/generate_junitxml.py@69 PS4, Line 69: content for the report. > I think this would be clearer if you just created this in init(). Done http://gerrit.cloudera.org:8080/#/c/11235/4/lib/python/impala_py_lib/jenkins/generate_junitxml.py@79 PS4, Line 79: elif os.path.exists(file_or_string): : with open(file_or_string, 'r') as > This is just: Done http://gerrit.cloudera.org:8080/#/c/11235/4/lib/python/impala_py_lib/jenkins/generate_junitxml.py@102 PS4, Line 102: help="If known, the elapsed time in seconds for this step.") : parser.add_argument("--stdout", : help=textwrap.dedent( > Same here: you don't re-use base_attributes ever, so I think it makes sense Done -- To view, visit http://gerrit.cloudera.org:8080/11235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I958ee0d8420b6a4197aaf0a7e0538a566332ea97 Gerrit-Change-Number: 11235 Gerrit-PatchSet: 5 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Nithya Janarthanan <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Thu, 16 Aug 2018 05:18:18 +0000 Gerrit-HasComments: Yes
