David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 )
Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11235/4/lib/python/impala_py_lib/jenkins/generate_junitxml.py File lib/python/impala_py_lib/jenkins/generate_junitxml.py: http://gerrit.cloudera.org:8080/#/c/11235/4/lib/python/impala_py_lib/jenkins/generate_junitxml.py@64 PS4, Line 64: """ : Derive additional conte > This is too fancy for my tastes. Perhaps just create the structures at the One last point. There's an additional (again, probably minor) benefit to retaining the @property approach. If one uses: init: self.make_root() self.attach_testsuite() self.attach_testcase() ...then the order of those lines is significant. If the file gets edited in the future and those somehow get shuffled, then the code would break. (It'll be obvious, but it's still slightly more brittle.) -- To view, visit http://gerrit.cloudera.org:8080/11235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I958ee0d8420b6a4197aaf0a7e0538a566332ea97 Gerrit-Change-Number: 11235 Gerrit-PatchSet: 5 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Nithya Janarthanan <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Thu, 16 Aug 2018 04:27:49 +0000 Gerrit-HasComments: Yes
