Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11410 )
Change subject: IMPALA-6249: Expose CMAKE_BUILD_TYPE via web UI for build type detection ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11410/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/11410/1/tests/webserver/test_web_pages.py@55 PS1, Line 55: def test_root_version(self): > Our tests currently support getting the version already, but that only work I started taking a look into this. The issue I'm hitting is that there is a dependency from bin/start-impala-cluster.py on environ.py IMPALA-6947 added logic to increase the value of -kudu_client_rpc_timeout_ms when running against a build that "runs_slowly" - e.g. a build that has code coverage enabled or is an asan, tsan, or ubsan build. So making environ.py depend on information from the web-ui introduces a circular dependency. start-impala-cluster.py can't start until it gets the build types from environ.py, but environ.py can't get the build types until the web ui is up and running. Do we expect remote clusters to run via the bin/start-impala-cluster.py script? I don't see a great way to get around this, but here are some ideas: (1) Start the impalad without the special timeout set, get the build info, shutdown the impala cluster, and then start it again with the new timeout set. Unless there is a way to dynamically change configurations in an impalad without a restart? (2) Just set a higher timeout for all build types. The drawback here is that we may lose some test coverage, unless we increase the default timeout for impala users too. (3) Will remote clusters be restricted to certain build types? Or is it possible they will be ASAN builds. (4) Just remove the special timeout for ASAN, basically revert IMPALA-6947 (5) De-couple the web ui and the impalad process? It sounds like this isn't possible today, and I'm guessing it would be a lot of effort. -- To view, visit http://gerrit.cloudera.org:8080/11410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47e3ad4cbf844909bdaf22a6f9d7bd915dce3f19 Gerrit-Change-Number: 11410 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Fri, 21 Sep 2018 20:51:14 +0000 Gerrit-HasComments: Yes
