Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11410 )
Change subject: IMPALA-6249: Expose CMAKE_BUILD_TYPE via web UI for build type detection ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/11410/1/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/11410/1/be/src/util/default-path-handlers.cc@228 PS1, Line 228: Value AddBuildFlag(const std::string& build_flag_name, const std::string& build_flag_value, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11410/1/be/src/util/default-path-handlers.cc@229 PS1, Line 229: Document* document) { tab used for whitespace http://gerrit.cloudera.org:8080/#/c/11410/1/be/src/util/default-path-handlers.cc@235 PS1, Line 235: return build_type; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/11410/1/be/src/util/default-path-handlers.cc@245 PS1, Line 245: document->GetAllocator()); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/11410/1/be/src/util/default-path-handlers.cc@247 PS1, Line 247: document->GetAllocator()); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/11410/1/be/src/util/default-path-handlers.cc@249 PS1, Line 249: document->GetAllocator()); tab used for whitespace -- To view, visit http://gerrit.cloudera.org:8080/11410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47e3ad4cbf844909bdaf22a6f9d7bd915dce3f19 Gerrit-Change-Number: 11410 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Sat, 22 Sep 2018 00:52:05 +0000 Gerrit-HasComments: Yes
