Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11410 )
Change subject: IMPALA-6249: Expose CMAKE_BUILD_TYPE via web UI for build type detection ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11410/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/11410/1/tests/webserver/test_web_pages.py@55 PS1, Line 55: def test_root_version(self): > That is unfortunate. I think we should consider reverting IMPALA-6947 and i Sure, I think its fine to revert IMPALA-6947 and do it a different way. -- To view, visit http://gerrit.cloudera.org:8080/11410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47e3ad4cbf844909bdaf22a6f9d7bd915dce3f19 Gerrit-Change-Number: 11410 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Mon, 24 Sep 2018 16:50:59 +0000 Gerrit-HasComments: Yes
