Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11410 )
Change subject: IMPALA-6249: Expose several build flags via web UI ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11410/1/be/src/util/debug-util.h File be/src/util/debug-util.h: http://gerrit.cloudera.org:8080/#/c/11410/1/be/src/util/debug-util.h@101 PS1, Line 101: std::string GetBuildType(); > It looks like CMAKE_BUILD_TYPE can take different values (CMake docs say "P I decided to keep this flag and to rename it to IsNDEBUG because thats really what its doing. I tried adding some static_asserts, but the Impala-lzo code wouldn't compile. I'm not entirely sure why, but my guess is that since Impala-lzo cmake doesn't contain the same build flags as Impala, there are issues during compilation. So instead I added a Python test to validate that the flags are consistent. http://gerrit.cloudera.org:8080/#/c/11410/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/11410/1/tests/webserver/test_web_pages.py@55 PS1, Line 55: def test_root_version(self): > Sure, I think its fine to revert IMPALA-6947 and do it a different way. Reverted the portion of IMPALA-6947 specific to -kudu_client_rpc_timeout_ms, instead the timeout is set at compile time if the build type is asan, tsan, ubsan, or has code coverage. I modified environ.py so that is supports fetching build flags from a remote cluster. If the env variable IMPALA_REMOTE_URL is set then environ.py will use the specified URL to fetch the build flags, otherwise it falls back to its old behavior. Looking through the tests, seems a lot of them are still hardcoded to connect to localhost (e.g. the websever) tests. However, this change is at least a start. -- To view, visit http://gerrit.cloudera.org:8080/11410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47e3ad4cbf844909bdaf22a6f9d7bd915dce3f19 Gerrit-Change-Number: 11410 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Wed, 26 Sep 2018 01:19:23 +0000 Gerrit-HasComments: Yes
