Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11949 )
Change subject: IMPALA-7869: break up parquet-column-readers.cc ...................................................................... Patch Set 8: (11 comments) http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/hdfs-parquet-scanner-test.cc File be/src/exec/parquet/hdfs-parquet-scanner-test.cc: http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/hdfs-parquet-scanner-test.cc@111 PS8, Line 111: void HdfsParquetScannerTest::TestDivideReservation(const vector<int64_t>& col_range_lengths, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/hdfs-parquet-scanner.cc@304 PS8, Line 304: int HdfsParquetScanner::CountScalarColumns(const vector<ParquetColumnReader*>& column_readers) { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/hdfs-parquet-scanner.cc@1388 PS8, Line 1388: RETURN_IF_ERROR(CreateCountingReader(tuple_desc.tuple_path(), schema_resolver, &reader)); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/hdfs-parquet-scanner.cc@1563 PS8, Line 1563: [&col_range_lengths](const pair<int, int64_t>& left, const pair<int, int64_t>& right) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/hdfs-parquet-scanner.cc@1601 PS8, Line 1601: bytes_to_add = max(min_buffer_size, BitUtil::RoundUpToPowerOfTwo(bytes_left_in_range)); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/hdfs-parquet-scanner.cc@1627 PS8, Line 1627: const vector<ParquetColumnReader*>& column_readers, int row_group_idx, int64_t rows_read) { line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/parquet-column-readers.h File be/src/exec/parquet/parquet-column-readers.h: http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/parquet-column-readers.h@382 PS8, Line 382: /// Try to move the the next page and buffer more values. Return false and sets rep_level_, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/parquet-column-readers.h@410 PS8, Line 410: /// 'data_page_pool_'. 'err_ctx' provides context for error messages. On success, 'buffer' line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/parquet-metadata-utils.cc File be/src/exec/parquet/parquet-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/parquet-metadata-utils.cc@376 PS8, Line 376: Status ParquetSchemaResolver::CreateSchemaTree(const vector<parquet::SchemaElement>& schema, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/parquet-metadata-utils.cc@481 PS8, Line 481: const SchemaPath& path, SchemaNode** node, bool* pos_field, bool* missing_field) const { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/parquet-metadata-utils.cc@699 PS8, Line 699: Status ParquetSchemaResolver::ResolveMap(const SchemaPath& path, int idx, SchemaNode** node, line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/11949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0efd5c50b781fe9e3c022b33c66c06cfb529c0b8 Gerrit-Change-Number: 11949 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Nov 2018 17:41:32 +0000 Gerrit-HasComments: Yes
