Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11949 )
Change subject: IMPALA-7869: break up parquet-column-readers.cc ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/11949/9/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/11949/9/be/src/exec/parquet/parquet-column-readers.cc@784 PS9, Line 784: bool ScalarColumnReader<TimestampValue, parquet::Type::INT64, true>::DecodeValues( I needed to add this specialisation in to call timestamp_decoder.DecodeBatch(). This fixes a bug that was revealed by removing encoding_ from ParquetLevelDecoder - int64_timestamps_plain.parq could no longer be scanned because max_level_ was 0, which meant that encoding_ in ParquetLevelDecoder got left as PLAIN, which effectively disabled that code path for the test file. After removing encoding_ it revealed the bug and caused a test failure. -- To view, visit http://gerrit.cloudera.org:8080/11949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0efd5c50b781fe9e3c022b33c66c06cfb529c0b8 Gerrit-Change-Number: 11949 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 26 Nov 2018 06:02:14 +0000 Gerrit-HasComments: Yes
