Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11949 )
Change subject: IMPALA-7869: break up parquet-column-readers.cc ...................................................................... Patch Set 8: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/parquet-collection-column-reader.h File be/src/exec/parquet/parquet-collection-column-reader.h: http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/parquet-collection-column-reader.h@17 PS8, Line 17: /// Collections are not materialized directly in parquet files; only scalar values appear nit: please add a blank line to separate the file comment from the license text http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/11949/8/be/src/exec/parquet/parquet-column-readers.cc@74 PS8, Line 74: defined nit: declared -- To view, visit http://gerrit.cloudera.org:8080/11949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0efd5c50b781fe9e3c022b33c66c06cfb529c0b8 Gerrit-Change-Number: 11949 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 22 Nov 2018 13:57:35 +0000 Gerrit-HasComments: Yes
