Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11949 )
Change subject: IMPALA-7869: break up parquet-column-readers.cc ...................................................................... Patch Set 8: Code-Review+1 (1 comment) lgtm Do you plan to fix the "line too long" issues? Or you want to minimize the "none move diff" in this change? I have added Zoltan, as he is also working in these parts of the code, so he should be familiar with this refactor. I can give +2 if the change is ok for him too. http://gerrit.cloudera.org:8080/#/c/11949/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11949/8//COMMIT_MSG@18 PS8, Line 18: Can you also mention the removal of encoding_ in ParquetLevelDecoder? I think that in a commit that is 95% moving code around it is important mention the exceptions where the code was actually changed. -- To view, visit http://gerrit.cloudera.org:8080/11949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0efd5c50b781fe9e3c022b33c66c06cfb529c0b8 Gerrit-Change-Number: 11949 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 21 Nov 2018 16:59:56 +0000 Gerrit-HasComments: Yes
