Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12052 )
Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement ...................................................................... Patch Set 6: Code-Review+1 (2 comments) I'm still not clear onhow shlex.split() differs from list(shlex.shlex()). I'll let some python guru +2 this. Just want to be sure I'm not overlooking something obvious. http://gerrit.cloudera.org:8080/#/c/12052/6/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/12052/6/shell/impala_shell.py@1149 PS6, Line 1149: lexer nit: tokens = .. (see below) http://gerrit.cloudera.org:8080/#/c/12052/6/shell/impala_shell.py@1155 PS6, Line 1155: tokens = list(lexer) I think shlex.split() directly returns a list. This is probably not needed? -- To view, visit http://gerrit.cloudera.org:8080/12052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I011b8e73a0477ac6b2357725452458f972785ae7 Gerrit-Change-Number: 12052 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 10 Dec 2018 18:01:18 +0000 Gerrit-HasComments: Yes
