Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12052 )
Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement ...................................................................... Patch Set 7: Code-Review+1 (2 comments) Carry Bharath's +1. http://gerrit.cloudera.org:8080/#/c/12052/6/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/12052/6/shell/impala_shell.py@1149 PS6, Line 1149: token > nit: tokens = .. (see below) Done http://gerrit.cloudera.org:8080/#/c/12052/6/shell/impala_shell.py@1155 PS6, Line 1155: if filter(self.DML_R > I think shlex.split() directly returns a list. This is probably not needed? Done -- To view, visit http://gerrit.cloudera.org:8080/12052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I011b8e73a0477ac6b2357725452458f972785ae7 Gerrit-Change-Number: 12052 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 10 Dec 2018 19:14:19 +0000 Gerrit-HasComments: Yes
