Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12217 )
Change subject: IMPALA-7679: Improve error message when adding NULL column in CTAS ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12217/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/12217/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1936 PS2, Line 1936: AnalyzesOk("create table t as select cast(null as int) as new_col"); Maybe add another test with multiple columns just to be a little more complete. -- To view, visit http://gerrit.cloudera.org:8080/12217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fe1fc96f0650477c0e897c010be3fadabfaf82 Gerrit-Change-Number: 12217 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 15 Jan 2019 21:06:48 +0000 Gerrit-HasComments: Yes
