Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12217 )
Change subject: IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12217/2/fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java: http://gerrit.cloudera.org:8080/#/c/12217/2/fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java@188 PS2, Line 188: if (colDef.getType() == Type.NULL) { > Putting it in ColumnDef seems wrong because NULL_TYPE is a valid type: http Hmm. While NULL is a valid type, I don't think a column definition with a NULL type makes much sense. Curious if you have an example that doesn't work if we force the check? Maybe I'm missing something. -- To view, visit http://gerrit.cloudera.org:8080/12217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fe1fc96f0650477c0e897c010be3fadabfaf82 Gerrit-Change-Number: 12217 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 16 Jan 2019 21:27:20 +0000 Gerrit-HasComments: Yes
