Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12217 )
Change subject: IMPALA-7679: Improve error message when adding NULL column in CTAS ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12217/2/fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java: http://gerrit.cloudera.org:8080/#/c/12217/2/fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java@188 PS2, Line 188: if (colDef.getType() == Type.NULL) { Thinking out loud, should we instead move this check up to ColumnDef#analyze() so that it can be used by any call path trying to create NULL type ColumnDefs? Ex: create view view_null as select NULL as null_literal ? -- To view, visit http://gerrit.cloudera.org:8080/12217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fe1fc96f0650477c0e897c010be3fadabfaf82 Gerrit-Change-Number: 12217 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 16 Jan 2019 00:21:42 +0000 Gerrit-HasComments: Yes
