Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12217 )
Change subject: IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/12217/2/fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java: http://gerrit.cloudera.org:8080/#/c/12217/2/fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java@188 PS2, Line 188: if (colDef.getType() == Type.NULL) { > Thinking out loud, should we instead move this check up to ColumnDef#analyz Putting it in ColumnDef seems wrong because NULL_TYPE is a valid type: https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java#L198. The NULL_TYPE only becomes an issue in certain statements, such as "create table as select", "create view", "alter view". http://gerrit.cloudera.org:8080/#/c/12217/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/12217/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1936 PS2, Line 1936: "Only scalar types are allowed in the select list."); > Maybe add another test with multiple columns just to be a little more compl Done. I also added test cases for "create view" and "alter view". -- To view, visit http://gerrit.cloudera.org:8080/12217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fe1fc96f0650477c0e897c010be3fadabfaf82 Gerrit-Change-Number: 12217 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 16 Jan 2019 08:01:28 +0000 Gerrit-HasComments: Yes
